Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Percent Unique #1273

Merged
merged 10 commits into from
Dec 15, 2020
Merged

Fix Percent Unique #1273

merged 10 commits into from
Dec 15, 2020

Conversation

jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez commented Dec 10, 2020 •
edited
Loading

Closes #1271 by dividing the unique value count by sample size.

@codecov
Copy link

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #1273 (d881995) into main (2b11e78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files         134      134           
  Lines       14440    14456   +16     
=======================================
+ Hits        14203    14220   +17     
+ Misses        237      236    -1
Impacted Files Coverage Δ
...eaturetools/tests/utils_tests/test_entity_utils.py 100.00% <100.00%> (ø)
featuretools/utils/entity_utils.py 99.21% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b11e78...d881995. Read the comment docs.

@jeff-hernandez jeff-hernandez marked this pull request as ready for review December 11, 2020 21:22
@jeff-hernandez jeff-hernandez requested review from rwedge and thehomebrewnerd and removed request for thehomebrewnerd December 14, 2020 16:49
rwedge
rwedge approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez jeff-hernandez merged commit 3e59aa6 into main Dec 15, 2020
@jeff-hernandez jeff-hernandez deleted the fix_percent_unique branch December 15, 2020 21:13
@rwedge rwedge mentioned this pull request Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd left review comments

@rwedge rwedge rwedge approved these changes

Assignees

@jeff-hernandez jeff-hernandez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infer Variable Types Always Returns Numeric For Input Numeric Fields, Regardless of Number of Unique Values.
3 participants
@jeff-hernandez @thehomebrewnerd @rwedge