Add pandas workaround back in #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
requested review from
thehomebrewnerd,
tamargrey and
a team
and removed request for
thehomebrewnerd and
tamargrey
|
@davesque this can merge into main, woodwork-integration branch has already been merged |
davesque
force-pushed
the
add-pandas-workaround
branch
from
3817834
to
aafaed3
Compare
davesque
force-pushed
the
add-pandas-workaround
branch
from
aafaed3
to
10364ec
Compare
davesque
force-pushed
the
add-pandas-workaround
branch
from
10364ec
to
9e72515
Compare
Codecov Report
@@ Coverage Diff @@
## main #1731 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 138 138
Lines 15361 15368 +7
=======================================
+ Hits 15161 15168 +7
Misses 200 200
Continue to review full report at Codecov.
|
thehomebrewnerd
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
@davesque No issues with the reverted changes, but just a couple comments:
- Have you been able to confirm that reverting these changes fixes the bug you were seeing?
- Can we create an issue to investigate this further and try to add tests to our test suite that will fail if remove this code with the current pandas version?
Yep, it fixes the issue. Confirmed that before making the PR.
There's a bullet point in the above PR description relating to this. I think the tests should be part of this PR. |
davesque
changed the title
davesque
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We realized earlier today that the pandas workarounds that were removed by #1677 and #1679 are probably still needed as the bug reported in pandas-dev/pandas#22501 may still exist. More investigation is needed to understand exactly what causes data frames with misaligned categorical indices to be merged incorrectly. For now, we should at least revert the changes made by the two aforementioned PRs.
Left to do:
_calculate_agg_featuresresulting from the categorical merge bug