Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory usage through support for pandas categorical types #196

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

kmax12
Copy link
Contributor

@kmax12 kmax12 commented Aug 1, 2018

Currently, we convert columns that are pandas categorical types to an object type. This is bad for memory usage.

This pull request changes removes that conversion so that the categorical dtype is preserved while running featuretools.

Test cases pass, but more integration and performance testing is needed.

@kmax12 kmax12 changed the title (WIP) Improve memory usage with support for pandas categorical types (WIP) Improve memory usage through support for pandas categorical types Aug 1, 2018
@codecov-io
Copy link

Codecov Report

Merging #196 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   93.21%   93.26%   +0.05%     
==========================================
  Files          70       70              
  Lines        7727     7726       -1     
==========================================
+ Hits         7203     7206       +3     
+ Misses        524      520       -4
Impacted Files Coverage Δ
featuretools/primitives/cum_transform_feature.py 97.63% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.25% <100%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 97.02% <100%> (+0.03%) ⬆️
featuretools/tests/testing_utils/mock_ds.py 87.4% <100%> (+0.18%) ⬆️
...turetools/computational_backends/pandas_backend.py 91.29% <100%> (ø) ⬆️
featuretools/entityset/entityset.py 94.59% <100%> (+0.77%) ⬆️
featuretools/utils/gen_utils.py 64.44% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee25b59...4c0513a. Read the comment docs.

@kmax12 kmax12 changed the title (WIP) Improve memory usage through support for pandas categorical types Improve memory usage through support for pandas categorical types Aug 13, 2018
@kmax12 kmax12 merged commit 94132fc into master Aug 13, 2018
@kmax12 kmax12 deleted the categorical_dtype_support branch August 15, 2018 23:02
@rwedge rwedge mentioned this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants