-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2179 Restructure Directories #2187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2187 +/- ##
===========================================
- Coverage 99.29% 73.49% -25.81%
===========================================
Files 145 266 +121
Lines 17556 18165 +609
===========================================
- Hits 17432 13350 -4082
- Misses 124 4815 +4691
Continue to review full report at Codecov.
|
from featuretools.primitives.aggregation import * | ||
from warnings import warn | ||
|
||
warn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this? Users have to change their import statements just because we re-organized directories?
I don't think that is ideal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if they happen to be importing that far down from featuretools.primitives.aggregation.api
Why is |
WIll change that back, was getting a little trigger happy :) |
The idea behind |
@dvreed77 do we still want to do this or should we close this PR? |
Closing in favor of #2331 |
Restructure Directories and Files to be more modular.
fixes #2179