Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2179 Restructure Directories #2187

Closed
wants to merge 33 commits into from
Closed

2179 Restructure Directories #2187

wants to merge 33 commits into from

Conversation

dvreed77
Copy link
Contributor

Restructure Directories and Files to be more modular.

fixes #2179

@dvreed77 dvreed77 self-assigned this Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #2187 (c38e999) into main (c8ed35a) will decrease coverage by 25.80%.
The diff coverage is 96.26%.

@@             Coverage Diff             @@
##             main    #2187       +/-   ##
===========================================
- Coverage   99.29%   73.49%   -25.81%     
===========================================
  Files         145      266      +121     
  Lines       17556    18165      +609     
===========================================
- Hits        17432    13350     -4082     
- Misses        124     4815     +4691     
Impacted Files Coverage Δ
featuretools/primitives/core/primitive_base.py 74.39% <ø> (ø)
featuretools/primitives/transform/rolling/utils.py 76.92% <ø> (ø)
...utational_backend/test_calculate_feature_matrix.py 100.00% <ø> (ø)
...mputational_backend/test_feature_set_calculator.py 100.00% <ø> (ø)
...rimitive_tests/primitives_to_install/custom_max.py 0.00% <0.00%> (-100.00%) ⬇️
...imitive_tests/primitives_to_install/custom_mean.py 0.00% <0.00%> (-100.00%) ⬇️
...rimitive_tests/primitives_to_install/custom_sum.py 0.00% <0.00%> (-100.00%) ⬇️
...aturetools/tests/primitive_tests/test_agg_feats.py 0.00% <0.00%> (-99.52%) ⬇️
...ts/primitive_tests/test_datetoholiday_primitive.py 0.00% <0.00%> (-100.00%) ⬇️
...rimitive_tests/test_distancetoholiday_primitive.py 0.00% <0.00%> (-100.00%) ⬇️
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ed35a...c38e999. Read the comment docs.

from featuretools.primitives.aggregation import *
from warnings import warn

warn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? Users have to change their import statements just because we re-organized directories?
I don't think that is ideal

Copy link
Contributor Author

@dvreed77 dvreed77 Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if they happen to be importing that far down from featuretools.primitives.aggregation.api

@rwedge
Copy link
Contributor

rwedge commented Jul 25, 2022

Why is primitives.base being renamed to primitives.core?

@dvreed77
Copy link
Contributor Author

Why is primitives.base being renamed to primitives.core?

WIll change that back, was getting a little trigger happy :)

@rwedge
Copy link
Contributor

rwedge commented Jul 25, 2022

The idea behind primitives.standard is that if a primitive was in that module, it was one of the primitives that was part of the basic featuretools installation. Since featuretools.primitives loads in primitives from other libraries via an entry point, featuretools.primitives isn't a good indicator of that.

@gsheni
Copy link
Contributor

gsheni commented Aug 8, 2022

@dvreed77 do we still want to do this or should we close this PR?

@thehomebrewnerd
Copy link
Contributor

Closing in favor of #2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure primitives folder and various util functions
5 participants