Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxCount, MedianCount, MaxMinDelta, NUniqueDaysX, NMostCommonFrequency, IsFirstWeekOfMonth #2533

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 6, 2023

@gsheni gsheni self-assigned this Apr 6, 2023
@gsheni gsheni requested a review from dvreed77 April 6, 2023 15:46
@gsheni gsheni marked this pull request as ready for review April 6, 2023 15:46
@gsheni gsheni requested a review from rwedge April 6, 2023 15:46
@gsheni gsheni requested a review from dvreed77 April 6, 2023 17:50
@rwedge
Copy link
Contributor

rwedge commented Apr 6, 2023

Should mention pinning pandas in the release notes

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #2533 (eddccda) into main (8ee07ef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
+ Coverage   99.45%   99.46%   +0.01%     
==========================================
  Files         379      389      +10     
  Lines       22550    22999     +449     
==========================================
+ Hits        22427    22876     +449     
  Misses        123      123              
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.71% <100.00%> (ø)
...etools/primitives/standard/aggregation/__init__.py 100.00% <100.00%> (ø)
...tools/primitives/standard/aggregation/max_count.py 100.00% <100.00%> (ø)
...s/primitives/standard/aggregation/max_min_delta.py 100.00% <100.00%> (ø)
...ls/primitives/standard/aggregation/median_count.py 100.00% <100.00%> (ø)
...es/standard/aggregation/n_most_common_frequency.py 100.00% <100.00%> (ø)
...s/primitives/standard/aggregation/n_unique_days.py 100.00% <100.00%> (ø)
...dard/aggregation/n_unique_days_of_calendar_year.py 100.00% <100.00%> (ø)
...ves/standard/aggregation/n_unique_days_of_month.py 100.00% <100.00%> (ø)
...primitives/standard/aggregation/n_unique_months.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsheni gsheni enabled auto-merge (squash) April 6, 2023 18:52
primitive = MaxMinDelta
array = pd.Series([1, 1, 2, 2, 3, 4, 5, 6, 7, 8])

def test_max_min_delta(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interested to see what happens with Inf values?

Copy link
Contributor

@dvreed77 dvreed77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides checking infinite values in max-min primitive

@gsheni gsheni merged commit cced793 into main Apr 6, 2023
@gsheni gsheni deleted the add_primitives branch April 6, 2023 19:16
@gsheni gsheni mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MaxCount, MedianCount, MaxMinDelta, NUniqueDaysX, NMostCommonFrequency, IsFirstWeekOfMonth
3 participants