-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MaxCount, MedianCount, MaxMinDelta, NUniqueDaysX, NMostCommonFrequency, IsFirstWeekOfMonth #2533
Conversation
gsheni
commented
Apr 6, 2023
•
edited
Loading
edited
- Fixes Add MaxCount, MedianCount, MaxMinDelta, NUniqueDaysX, NMostCommonFrequency, IsFirstWeekOfMonth #2534
featuretools/tests/primitive_tests/aggregation_primitive_tests/test_agg_primitives.py
Show resolved
Hide resolved
featuretools/tests/primitive_tests/aggregation_primitive_tests/test_agg_primitives.py
Show resolved
Hide resolved
Should mention pinning pandas in the release notes |
Codecov Report
@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
+ Coverage 99.45% 99.46% +0.01%
==========================================
Files 379 389 +10
Lines 22550 22999 +449
==========================================
+ Hits 22427 22876 +449
Misses 123 123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
primitive = MaxMinDelta | ||
array = pd.Series([1, 1, 2, 2, 3, 4, 5, 6, 7, 8]) | ||
|
||
def test_max_min_delta(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interested to see what happens with Inf values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides checking infinite values in max-min primitive