Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change time since return type to numeric #606

Merged
merged 2 commits into from Jun 19, 2019
Merged

Change time since return type to numeric #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb9dd8d
change return type to numeric
kmax12 Jun 19, 2019
0a1420a
Update changelog.rst
kmax12 Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/changelog.rst
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ Changelog
* Improved error message for index/time_index being the same column in normalize_entity and entity_from_dataframe (:pr:`583`)
* Removed all mentions of allow_where (:pr:`587`, :pr:`588`)
* Removed unused variable in normalize entity (:pr:`589`)
* Change time since return type to numeric (:pr:`606`)
* Changes
* Refactor get_pandas_data_slice to take single entity (:pr:`547`)
* Updates TimeSincePrevious and Diff Primitives (:pr:`561`)
Expand Down
3 changes: 1 addition & 2 deletions featuretools/primitives/standard/transform_primitive.py
View file
Open in desktop
Expand Up @@ -17,7 +17,6 @@
Numeric,
Ordinal,
Text,
Timedelta,
Variable
)

Expand Down Expand Up @@ -369,7 +368,7 @@ class TimeSince(TransformPrimitive):
"""
name = 'time_since'
input_types = [[DatetimeTimeIndex], [Datetime]]
return_type = Timedelta
return_type = Numeric
uses_calc_time = True

def __init__(self, unit="seconds"):
Expand Down