-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More descriptive DFS progress bar #69
Conversation
…gress feature construction
new_features = self._filter_features(new_features) | ||
if verbose and before_len > len(new_features): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this look like when it gets written?
I like the main change, but not sure it's that helpful to have this print out as things are removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually looks pretty good I think, try running it and check it out.
Basically the progress bar is like:
[45 features] 100 features/s
Eventually the feature building stops and the progress bar stops, then above the progress bar the number removed is written:
Removed 2 features with undesired variable types
Removed 2 features from drop_contains list
[45 features] 100 features/s
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 88.3% 88.33% +0.02%
==========================================
Files 73 73
Lines 7447 7439 -8
==========================================
- Hits 6576 6571 -5
+ Misses 871 868 -3
Continue to review full report at Codecov.
|
Yup that all makes sense. I didn't test the actual feature calculation step, just the building step (because I noticed what we show for that step right now doesn't make much sense). |
…gress feature construction
7aea72f
to
84316cd
Compare
I didn't see that line- should be fixed now |
Looks great! |
Updated DFS progress bar to display number of features actually constructed, as well features removed at the end due to restrictions on variable types and the drop_contains/drop_exact list.