Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dask dataframe during entity creation #783
Allow dask dataframe during entity creation #783
Changes from 113 commits
0e3ba63
adbc1e8
e91c564
805abed
789551f
280bb6c
d722058
1e0f3a4
c35c839
f567379
d74a83d
93eacb7
db0f63e
b2ce33f
6ec74ff
b9aa184
84bce89
b056bd7
bf19155
21632d5
1507f81
ee280fa
36a6ad8
bc4103a
245d5eb
7e896e0
859e5ac
4b477c8
021423f
5dbe6d3
815cc47
0472448
f868120
ffc3dd3
2bd87a9
a4cdff3
c9a6c65
f4ee1cd
2970842
806c563
673db93
e23ab59
fea42c6
33cad04
c98526a
b3bbb34
07d9125
1ec303f
7ea1a9f
f304abc
2c06b74
756d761
ce82e19
970c228
132e432
d3ba08b
ad0a1c3
1c270fe
ac3a1b4
5ebd81e
05a25a1
c7edc0b
9501916
5403297
11e9696
f55133c
c129cff
c581bc2
ff6fce3
fc62201
38150d8
35159b2
32edf90
277a7bb
d1aa368
e6d2418
3111a1d
2fd10cf
77904c3
43ec29c
c7fc449
01d2ecd
a1c57e5
07cc538
d941445
e413378
308c41e
8bc603a
e7de404
8a30486
9350cdd
d0cbd2c
2d3230c
b8570b0
572acc8
f901a75
17f7dc3
a742656
af0a552
223d154
e809e11
cd1d58c
f5b38c1
a22dd75
9ef79e2
71d45fb
b07d0de
87d91a6
f030ed8
1338439
200eb10
9fa22bb
2ab61a9
2663622
cd275a2
1f4fe5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd move this section up to the top and we need to also edit the "Running Featuretools with Spark and Dask" section to align with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to make sure I fully understand this comment...
So, you want this new Dask section to be the very first section in the document instead of the last?
Can you provide a little more info on what you are thinking in regards to aligning the "Running Featuretools with Spark and Dask" section with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
Right now that section says "If you have a big data problem and are interested in testing our latest Dask or Spark integrations for free, please let us know by completing this simple request form."
However, if they want to use dask, they dont need to fill out the form since dask is now released. They should still fill out the form for spark though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmax12 If we remove the reference to Dask in this section (and the corresponding section in
Improving Computational Performance
- we also need to update the linked request form which still mentions Dask. Can you update that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, ill do that right after we release! thanks for the reminder