Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For n_jobs, close client before tearing down cluster #853

Merged
merged 2 commits into from Feb 28, 2020

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Feb 28, 2020

Should fix #852

Shutting down the dask scheduler before the client occasionally caused "Connection closed" errors to pop up. Shutting down the client first seems to resolve this problem.

@kmax12
Copy link
Contributor

kmax12 commented Feb 28, 2020

Codecov Report

Merging #853 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         117      117           
  Lines       10812    10812           
=======================================
  Hits        10611    10611           
  Misses        201      201           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d025c...66f219f. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         117      117           
  Lines       10812    10812           
=======================================
  Hits        10611    10611           
  Misses        201      201
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 98.58% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d025c...9a8072d. Read the comment docs.

@rwedge rwedge requested a review from kmax12 February 28, 2020 16:10
@rwedge rwedge merged commit 5f4b395 into master Feb 28, 2020
@rwedge rwedge deleted the close-client-before-scheduler branch February 28, 2020 17:08
@rwedge rwedge mentioned this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

featuretools dfs, Stream closed error issue in linux
3 participants