-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NumberOfHashtags and NumberOfMentions primitives #180
Conversation
sbadithe
commented
Jul 22, 2022
•
edited
Loading
edited
- Fixes Add NumberOfHashtags primitive #139
- Fixes Add NumberOfMentions primitive #140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments about what we consider valid hashtags and mentions. If we make changes to the regex, we'll also need to update the associated tests accordingly.
Aside from some questions about what is a valid hashtag or mention, this PR looks pretty good to me.
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 99.08% 99.16% +0.08%
==========================================
Files 43 47 +4
Lines 1089 1199 +110
==========================================
+ Hits 1079 1189 +110
Misses 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. |
…mitives into NumberOfHashtags
@sbadithe What is the status of this? Ready for another review? |
Still working on this. Trying to get all the edge cases to work (as well as Unicode) by referencing Twitter's open source implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a few wording suggestions. Also, the comments that I left on the docstrings apply to both primitives, although I left them in only one place.