Add NumberOfHashtags and NumberOfMentions primitives

[sbadithe]

• Fixes Add NumberOfHashtags primitive #139
• Fixes Add NumberOfMentions primitive #140

[thehomebrewnerd]

I have a few comments about what we consider valid hashtags and mentions. If we make changes to the regex, we'll also need to update the associated tests accordingly.

Aside from some questions about what is a valid hashtag or mention, this PR looks pretty good to me.

[codecov]

Codecov Report

Merging #180 (e83a14f) into main (11837a5) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   99.08%   99.16%   +0.08%     
==========================================
  Files          43       47       +4     
  Lines        1089     1199     +110     
==========================================
+ Hits         1079     1189     +110     
  Misses         10       10              

Impacted Files	Coverage Δ
nlp_primitives/__init__.py	100.00% <100.00%> (ø)
nlp_primitives/number_of_hashtags.py	100.00% <100.00%> (ø)
nlp_primitives/number_of_mentions.py	100.00% <100.00%> (ø)
nlp_primitives/tests/test_number_of_hashtags.py	100.00% <100.00%> (ø)
nlp_primitives/tests/test_number_of_mentions.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

[gsheni]

@sbadithe What is the status of this? Ready for another review?

[sbadithe]

@sbadithe What is the status of this? Ready for another review?

Still working on this. Trying to get all the edge cases to work (as well as Unicode) by referencing Twitter's open source implementation.

[thehomebrewnerd]

Looks pretty good, just a few wording suggestions. Also, the comments that I left on the docstrings apply to both primitives, although I left them in only one place.