Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Primitives to use Count String #183

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Refactor Primitives to use Count String #183

merged 7 commits into from
Jul 25, 2022

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Jul 22, 2022 •
edited
Loading

gsheni
gsheni previously approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thehomebrewnerd
thehomebrewnerd reviewed Jul 25, 2022
View reviewed changes
docs/source/changelog.rst Outdated Show resolved Hide resolved
nlp_primitives/punctuation_count.py Outdated Show resolved Hide resolved
nlp_primitives/title_word_count.py Outdated Show resolved Hide resolved
nlp_primitives/upper_case_count.py Outdated Show resolved Hide resolved
thehomebrewnerd
thehomebrewnerd approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbadithe sbadithe merged commit 5fd1d45 into main Jul 25, 2022
@sbadithe sbadithe deleted the Refactor-To-Use-Count-String branch July 25, 2022 16:53
@thehomebrewnerd thehomebrewnerd mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd approved these changes

@gsheni gsheni gsheni left review comments

Assignees

@sbadithe sbadithe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor primitives to use count_string where applicable
3 participants
@sbadithe @thehomebrewnerd @gsheni