Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null invalid age #1462

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Null invalid age #1462

merged 5 commits into from
Jul 1, 2022

Conversation

jeff-hernandez
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2022 •
edited
Loading

Codecov Report

Merging #1462 (62fa1ec) into main (c8cd1a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          97       97           
  Lines       10551    10592   +41     
=======================================
+ Hits        10408    10449   +41     
  Misses        143      143
Impacted Files Coverage Δ
woodwork/logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/logical_types/test_logical_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cd1a6...62fa1ec. Read the comment docs.

@jeff-hernandez jeff-hernandez marked this pull request as ready for review June 30, 2022 21:56
ParthivNaresh
ParthivNaresh approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me!

bchen1116
bchen1116 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-hernandez jeff-hernandez merged commit 957379b into main Jul 1, 2022
@jeff-hernandez jeff-hernandez deleted the null-invalid-age branch July 1, 2022 15:42
@ParthivNaresh ParthivNaresh mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchen1116 bchen1116 bchen1116 approved these changes

@ParthivNaresh ParthivNaresh ParthivNaresh approved these changes

Assignees

@jeff-hernandez jeff-hernandez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-hernandez @bchen1116 @ParthivNaresh