Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dask upper version limit #1527

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Remove Dask upper version limit #1527

merged 3 commits into from
Sep 19, 2022

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Sep 19, 2022

Removes the upper bound on dask[dataframe] and updates test_to_disk_with_latlong to ignore the index column since we can't rely on Dask maintaining the index column during serialization and the latlong_df fixture does not utilize an index column, so the underlying dataframe range/int index isn't meaningful in the test.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1527 (e53a562) into main (0844dee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1527   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          95       95           
  Lines       10969    10969           
=======================================
  Hits        10828    10828           
  Misses        141      141           
Impacted Files Coverage Δ
woodwork/tests/accessor/test_serialization.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thehomebrewnerd thehomebrewnerd merged commit e09f7df into main Sep 19, 2022
@thehomebrewnerd thehomebrewnerd deleted the remove-dask-limit branch September 19, 2022 21:19
@bchen1116 bchen1116 mentioned this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dask 2022.8.0
2 participants