Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __eq__ to DataTable and DataColumn and update LogicalType equality #318

Merged
merged 9 commits into from
Oct 27, 2020

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey requested a review from gsheni October 27, 2020 17:17
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsheni
Copy link
Contributor

gsheni commented Oct 27, 2020

@tamargrey The unit tests are failing due to Dask Series and checking equality.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #318 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #318    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           24        24            
  Lines         2688      2788   +100     
==========================================
+ Hits          2688      2788   +100     
Impacted Files Coverage Δ
woodwork/data_column.py 100.00% <100.00%> (ø)
woodwork/data_table.py 100.00% <100.00%> (ø)
woodwork/logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/data_column/test_data_column.py 100.00% <100.00%> (ø)
woodwork/tests/data_table/test_datatable.py 100.00% <100.00%> (ø)
woodwork/tests/logical_types/test_logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/test_utils.py 100.00% <100.00%> (ø)
woodwork/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662c1b7...ed9a514. Read the comment docs.

@tamargrey tamargrey merged commit d6b9138 into main Oct 27, 2020
@gsheni gsheni mentioned this pull request Nov 11, 2020
@gsheni gsheni deleted the equality branch November 13, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add __eq__ (equality) to DataTable
3 participants