-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __eq__ to DataTable and DataColumn and update LogicalType equality #318
Conversation
tamargrey
commented
Oct 26, 2020
- Adds eq to DataTable and DataColumn and updates LogicalType equality to account for parameters
- Closes Add __eq__ (equality) to DataTable #167 and Add __eq__ (equality) to DataColumn #208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@tamargrey The unit tests are failing due to Dask Series and checking equality. |
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 24 24
Lines 2688 2788 +100
==========================================
+ Hits 2688 2788 +100
Continue to review full report at Codecov.
|