Remove no selected columns warning #325
Conversation
gsheni
commented
Oct 28, 2020
gsheni
commented
- Closes DataTable.select warns if no columns match #322
Codecov Report
@@ Coverage Diff @@
## main #325 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 2788 2741 -47
=========================================
- Hits 2788 2741 -47
Continue to review full report at Codecov.
|
| @@ -1670,37 +1619,6 @@ def test_select_list_inputs(sample_df): | |||
| assert 'signup_date' in dt_common_tags.columns | |||
|
|
|||
|
|
|||
| def test_select_warnings(sample_df): | |||
There was a problem hiding this comment.
What to you think about leaving this test in place, renaming it to something more appropriate and just removing the with pytest.warns blocks. That way we have a test that confirms the proper behavior when we use an invalid selector, either alone or in combination with other valid selectors? I'm not sure we are testing that anywhere else.
Also, might consider adding assertions to confirm the underlying dataframe is empty or has the correct columns as well, in addition to just checking the DataTable.columns.
There was a problem hiding this comment.
Added test back, and renamed it. It also handles the situation of checking that empty datatable is returned.
|
I think we should also remove the warning here. It is basically warning of the same thing, except inside of |
