Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install workflow to test update checker #970

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Add install workflow to test update checker #970

merged 3 commits into from
Jun 9, 2021

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 8, 2021 •
edited
Loading

  • This PR tests that the update checker + other future add-ons can be properly installed, and used in WW.

@gsheni gsheni changed the title Create install_test.yml Add install workflow to test add-ons Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #970 (f8d7cd6) into main (f8e2ceb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #970   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          45       45           
  Lines        7549     7549           
=======================================
  Hits         7543     7543           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e2ceb...f8d7cd6. Read the comment docs.

@gsheni gsheni self-assigned this Jun 8, 2021
@gsheni gsheni requested a review from frances-h June 8, 2021 18:32
@gsheni gsheni marked this pull request as ready for review June 8, 2021 18:32
@gsheni gsheni requested review from jeff-hernandez and removed request for frances-h June 9, 2021 14:06
@gsheni gsheni changed the title Add install workflow to test add-ons Add install workflow to test update checker Jun 9, 2021
jeff-hernandez
jeff-hernandez approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@jeff-hernandez jeff-hernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs a minor update

.github/workflows/install_test.yml Outdated Show resolved Hide resolved
@gsheni gsheni merged commit 5438e93 into main Jun 9, 2021
@gsheni gsheni deleted the add_install_workflow branch June 9, 2021 14:25
@thehomebrewnerd thehomebrewnerd mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-hernandez jeff-hernandez jeff-hernandez approved these changes

Assignees

@gsheni gsheni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsheni @jeff-hernandez