New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sys package called before import #29

Closed

EmersonYe opened this issue Aug 2, 2018 · 1 comment

Contributor

EmersonYe commented Aug 2, 2018

sys.exit(1) is called without importing the sys package when exiting due to not finding Dolphin home directory.

libmelee/melee/dolphin.py

Line 159 in af16292

sys.exit(1)

NameError: name 'sys' is not defined exception is thrown instead of a graceful exit when the line is called.

The text was updated successfully, but these errors were encountered:

EmersonYe mentioned this issue

Add missing sys import to melee/dolphin.py #30

Closed

Contributor Author

EmersonYe commented Aug 2, 2018 •

edited

Loading

PR to import sys before sys.exit(1)created here: #30.

altf4 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment