Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is comma actually an invalid SMB path character? #32

Closed
SamRWest opened this issue Aug 20, 2021 · 3 comments
Closed

Is comma actually an invalid SMB path character? #32

SamRWest opened this issue Aug 20, 2021 · 3 comments

Comments

@SamRWest
Copy link

Hi,

I've posted the details in the PyFilesystem2 issue here:
PyFilesystem/pyfilesystem2#494

But now realise that this is probably best asked in this project.

It boils down to the question: are commas actually invalid SMB path characters? They seem to work fine for me, yet are included in fs.smbfs.SMBFS._meta['invalid_path_chars'].

Is this a bug?

Cheers,
Sam.

@althonos
Copy link
Owner

Hi @SamRWest

Actually, I don't think it is. I'll make a patch release to fix that.

@althonos althonos added the bug label Aug 24, 2021
@althonos
Copy link
Owner

Fixed in v1.0.3.

@SamRWest
Copy link
Author

Brilliant, thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants