Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkDotNet error: FluentResults is non-optimized #194

Closed
bagoette opened this issue Aug 25, 2023 · 3 comments
Closed

BenchmarkDotNet error: FluentResults is non-optimized #194

bagoette opened this issue Aug 25, 2023 · 3 comments
Labels

Comments

@bagoette
Copy link

I was trying to run some benchmarks on a method that was returning a Result and BenchmarkDotNet gives the following error:

image

  • Versions
    • FluentResults 3.15.2 (but I've tried all versions back to 3.14.0)
      • I can't find this release version on GitHub
    • BenchmarkDotNet 0.13.7

I don't benchmark very often so maybe this is expected when using a Nuget, however, I thought I'd bring it up in case the build is misconfigured.

I can run the benchmarks by disabling the optimization validator so this isn't a road block for me.

I have a reproducible project here: https://github.com/bagoette/fluent-results-repro

@saborrie
Copy link

saborrie commented Nov 7, 2023

probably related to #195

@WojciechNagorski
Copy link

@altmann Can we fix this problem? I don't see the build script in the repo, so I can't prepare a PR.

@altmann
Copy link
Owner

altmann commented Jun 30, 2024

Implemented with v3.16

@altmann altmann closed this as completed Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants