-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weird format time bug in moment #15
Comments
your format string should be |
ah, damn it! you are correct! |
Hi, just wondering.. I checked moment.js and they are using "mm" for minutes and "MM" for months. Do you think it would be possible to adjust this component to be fully compatible with the moment syntax? |
I don't see an overwhelming case for it. We're not aiming for complete parity with moment.js, and the current implementation is very much in line with dateTimeFormat() masks (in most cases, simply delegating to that method), which makes it familiar for existing CFML developers. I'm not saying no, I'm saying convince me. ;) |
Yeah, you are absolutely correct that the format does comply with the CF date/time format. Honestly I am not sure which way is better, but I do tend to put "mm" for months as a force of habbit and can imagine others, having worked with moment.js, will too. So, this would be a pure convenience change. |
I get 12:02 PM and that is wrong.....
The text was updated successfully, but these errors were encountered: