Removed flatMap, added TODOs and link to GH issue

alxmrs · Mar 3, 2020 · 140111f · 140111f
1 parent 472bc84
commit 140111f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/runtime/manifest.ts b/src/runtime/manifest.ts
@@ -174,7 +174,7 @@ export class Manifest {
     return [...new Set(this._findAll(manifest => manifest._recipes))];
   }
   get allHandles() {
-    // Reduce is equivalent to flatMap
+    // TODO(#4820) Update `reduce` to use flatMap
     return [...new Set(this._findAll(manifest => manifest._recipes.reduce((acc, x) => acc.concat(x.handles), [])))];
   }
   get activeRecipe() {
@@ -329,8 +329,9 @@ export class Manifest {
     function fatePredicate(handle: Handle) {
       return fates === [] || fates.includes(handle.fate);
     }
+    // TODO(#4820) Update `reduce` to use flatMap
     return [...this._findAll(manifest => manifest._recipes
-      .flatMap(r => r.handles)
+      .reduce((acc, r) => acc.concat(r.handles), [])
       .filter(h => this._typePredicate(h, type, subtype) && tagPredicate(h) && fatePredicate(h)))];
   }
   findHandlesById(id: string): Handle[] {