-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images not being exported for Notebook with apostrophe #90
Comments
Thank for your report. Sorry but I will be very busy the next few months and will not be able to have a look to the issue. Hopefully, a kind contributor will take a look at your problem. |
I found that removing the apostrophe (i.e. "Michaels's Notebook" -> "Michaels Notebook") fixed this issue for me. I suspect there's something going on with the character conversion in the path somewhere but I was unable to track it down in the short period of time I had to look at it. |
Thanks a lot a for the feedback. I will try to solve the issue in the next version of the tool*. |
Related to #80 |
I did not managed to reproduce the bug. Do you mind to send me a sample Onenote notebook that cause the crash to append ? |
Hi, I created a PR fix for this, as it happened with my notebook, titled: Paul's Notebook. I think any 'special' HTML character would cause the issue, as attachment paths were being translated like this:
And great tool by the way! Not sure what I would have done without it 🙏 |
Thanls a lot for the PR, I will review it as soon as possible. |
Thanks again to reproduce and fix the bug @armstrong-pv ! The fix is embedded in version 1.4. |
Describe the bug
Images are not being exported for some reason.
To Reproduce
Steps to reproduce the behavior.
Attempt to export any of my notebooks.
All of the images fail with the below error. No other errors are logged.
Expected behavior
I hoped images would be exported.
Logs
Here is the error:
[15:49:21 WRN] Page 'Joshua's Notebook\Quick Notes\Photo IMG_8689': Error while extracting images of the page.
Nothing else seems out of the ordinary. Happy to private message the logs file to anyone who can help.Desktop (please complete the following information):
Additional context
Failed across all of my notebooks.
The text was updated successfully, but these errors were encountered: