Feat: Display of last opened of each file #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Gradle doesn't build on testing it, I would recommend @cpg to reject this. |
|
@Akash-Ramjyothi can you post the error here? |
|
@Akash-Ramjyothi will submit an improved PR for this feature. |
|
I have done. It is PR #536.
…On Wed, Jun 17, 2020, 7:27 PM Carlos Puchol ***@***.***> wrote:
@Akash-Ramjyothi <https://github.com/Akash-Ramjyothi> will submit an
improved PR for this feature.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#489 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM43USEJKWZRVM54XRPDBSDRXDDVXANCNFSM4IG6UQPQ>
.
|
|
I have tested this on my Samsung phone and I see two file for each file I open , the first one of the files is 0 k size |
|
leaving it to #536 |
|
Fixed in #574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488
Changes made
a new database table to store the last opened of each file
migrated room database version from 1 to 2
added a new file option called file info and on clicking the option a dialog with last opened will be shown
Screenshots
