Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching activity needs to change, logically Authentication activity should first to appear #59

Closed
sukhbir-singh opened this issue Mar 9, 2017 · 3 comments

Comments

@sukhbir-singh
Copy link
Member

sukhbir-singh commented Mar 9, 2017

When we open the app in signed out state. The first activity that is appearing on screen is Navigation activity. Then after checking authentication through service, app gets redirected to AuthenticationActivity for asking user credentials. This is the current app flow.

The point is that logically if the app is in signed out state, Authentication activity should be the first activity to appear in front of user, not the Navigation activity.

I want to fix this app flow. But need some discussion.

@sukhbir-singh
Copy link
Member Author

sukhbir-singh commented Mar 9, 2017

I am thinking of implementing this with the help of SharedPreference. By adding a boolean key "auth" to false by default and setting it to true when user logged in successfully. By checking value of this key, we can check user authentication in Authentication activity.

Should I look forward to implement this??

@Jagruti1010
Copy link

Jagruti1010 commented Mar 22, 2017

should i send PR ? I can help out in this. @sukhbir-singh

@cpg
Copy link
Member

cpg commented Apr 13, 2017

No action on this. If the first activity appearing is not the login page, I cannot see it well. Maybe it's too fast.

@cpg cpg closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants