Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Default System Language Option in Settings #733

Closed
Prakhar-Agarwal-byte opened this issue Jan 27, 2021 · 0 comments · Fixed by #734
Closed

Adding Default System Language Option in Settings #733

Prakhar-Agarwal-byte opened this issue Jan 27, 2021 · 0 comments · Fixed by #734
Assignees

Comments

@Prakhar-Agarwal-byte
Copy link
Contributor

Describe the issue
In the Amahi Android app, we can add a new feature that allows users to select the default system language as the in-app language as well. It will make a great feature, as mostly users prefer to use the language in their apps same as the system language. If the app does not support the language which the user has set as system language then the app will use English Language as in-app language.

To Reproduce or Feature details
Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on Language
  3. Select System Default from the dialog
  4. See that the language changes to the system language.

Expected behavior

In the language chooser dialog box, a new option should be added named "System Default". On choosing this option the in-app language should change to the system language if it is supported by the app or else it should fallback to English as the in-app language.

Demo Recording

In the demo below, I first changed the system language to Hindi then I chose the System Default option in the Language dialog box. Now, we see that the language automatically changes to the chosen system language i.e. Hindi, and since Hindi is supported by the app, therefore, our in-app language changes to Hindi. If that wouldn't be the case then it would have fallen back to English. Finally, for confirming that it works I changed it to another language as well.

Android.Emulator.-.Pixel_4_API_21_5554.2021-01-27.22-15-26_Trim.mp4

Smartphone (please complete as much of the following information as possible):

  • All supported Android devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants