App is crashing on changing Orientation in login Screen

[doomers]

App is crashing on changing the Orientation in Login Screen.

Screenshots :

@cpg this is needed to be fix as soon as possible.
shall i send a PR for this?

[cpg]

I think @csoni111 identified it in a bad identifier here, but sure.

[cpg]

Created a wiki page for checklist for new releases so that we remember to test everything and we do not miss things like this.

Feel free to contribute.

[doomers]

Okay I am working on it, will create a PR tomorrow

[csoni111]

@cpg the one that I mentioned here is another bug. In that opening the apps page crashes the app.

This one is happening because there are two layout for the login screen, one for the portrait mode and another for landscape mode. Now in pr #81 @Ishmeetsingh97 made the layout changes only for portrait one. The landscape one is still older. Hence the crash.

[sukhbir-singh]

Yes as explained by @csoni111, you need to make same changes to landscape mode as made in portrait mode by PR #81
The app is getting Null pointer exception because of unavailability of TextInputLayout.getEditText() in landscape mode.

[doomers]

@sukhbir-singh Yes i know ,i have already figured it out,
And started working on it, i will send the PR tomorrow.

[csoni111]

@doomers while you are on this, pls make one more change! The Username field is still EditText while the Password field was changed to TextInputLayout.
So change the username field also to TextInputLayout. That way it will look better!

[csoni111]

@doomers so sorry for solving the issue that you mentioned and asked to do. But @cpg asked me to complete it asap, as another issue was pending because of this.

[cpg]

@doomers please review #90 when you can. I asked @csoni111 to work on this because it was blocking something else for me.

[doomers]

@cpg @csoni111 no problem if this issue is needed to be solved asap, but I was unaware that you had also a PR when I made this PR, but now as I have done it in #91, it would be great if you can merge mine first
and work on issue after the merge and create a separate PR, as it would a transparency of what changes have been done in which PR, as your PR is not reflecting that you have fixed any Orientation based fixes

[csoni111]

@doomers, @cpg : The app built by the code in the current master branch, still crashes on logging in while in landscape mode. Will open a new pr for this.

Also there is another bug that I found, shall open a new issue for that!

[cpg]

Oops, landscape is still still crashing.

[doomers]

@cpg @csoni111 but it is now working fine in my device, Can you share the logcat or Screenshots here.

[csoni111]

Sorry to bother everyone, I think I might have tested the code from other branch. Just got confused with all the code changes.
It works fine now. This issue can be closed @cpg.