-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashes with the newly added search feature #95
Comments
@csoni111 thanks for reporting the bugs. Please go ahead. |
This helps! Also I have some other code changes in mind to further improve the search functionality. Will make a pr for all those. |
@csoni111 see #30 @lakshyagupta21 is already working on it, the Vector Drawable part |
Yes I know that, I will just update the search icon that has been added recently. He might not have pulled this change. |
Okay. |
@octacode I have made the pr. Please review it if possible! |
The search feature implemented in #36 by @octacode is a great addition but unfortunately it has some bugs.
To reproduce the bug first type something in the search bar and then with the search query typed in, click on a
directory
to open its content. Now if you type anything more in the search bar, the app crashes.Also instead of adding 5 images for different sizes, a single vector drawable can be added.
I would like to send a pr for resolving this bug.
The text was updated successfully, but these errors were encountered: