Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icebreaker: fix UART flow control pins. #69

Closed
wants to merge 1 commit into from

Conversation

alanvgreen
Copy link
Contributor

@alanvgreen alanvgreen commented Jun 22, 2020

Adds a role attribute to the ICEBreakerPlatform's UARTResource.

Since commit 5d56f7f all uses of
UARTResource must specify a role attribute. Without this role attribute,
icebreaker.py cannot be imported.

Adds a role attribute to the ICEBreakerPlatform's UARTResource.

Since commit 5d56f7f all uses of
UARTResource must specify a role attribute. Without this role attribute,
icebreaker.py cannot be imported.
@alanvgreen
Copy link
Contributor Author

alanvgreen commented Jun 22, 2020

I chose "dce" as the value for the role attribute. I'm not entirely sure this is right. However, I figured it was better to have a slightly wrong but importable ICEBreakerPlatform than to have an unimportable ICEBreakerPlatform.

@whitequark
Copy link
Member

whitequark commented Jun 22, 2020

There's no control flow on icebreaker, so the role is irrelevant.

@whitequark
Copy link
Member

whitequark commented Jun 22, 2020

Fixed in a889afe.

@whitequark whitequark closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants