icebreaker: fix UART flow control pins. #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a role attribute to the ICEBreakerPlatform's UARTResource. Since commit 5d56f7f all uses of UARTResource must specify a role attribute. Without this role attribute, icebreaker.py cannot be imported.
|
I chose "dce" as the value for the role attribute. I'm not entirely sure this is right. However, I figured it was better to have a slightly wrong but importable ICEBreakerPlatform than to have an unimportable ICEBreakerPlatform. |
|
There's no control flow on icebreaker, so the role is irrelevant. |
|
Fixed in a889afe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a role attribute to the ICEBreakerPlatform's UARTResource.
Since commit 5d56f7f all uses of
UARTResource must specify a role attribute. Without this role attribute,
icebreaker.py cannot be imported.