Skip to content

lib.fifo.AsyncFFSynchronizer: check input and output signal width#517

Merged
whitequark merged 1 commit into
amaranth-lang:masterfrom
rroohhh:master
Oct 28, 2020
Merged

lib.fifo.AsyncFFSynchronizer: check input and output signal width#517
whitequark merged 1 commit into
amaranth-lang:masterfrom
rroohhh:master

Conversation

@rroohhh

@rroohhh rroohhh commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

wasted more time than I would like to admit due to this :)

@codecov

codecov Bot commented Oct 27, 2020

Copy link
Copy Markdown

Codecov Report

Merging #517 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   81.37%   81.38%   +0.01%     
==========================================
  Files          49       49              
  Lines        6410     6414       +4     
  Branches     1280     1282       +2     
==========================================
+ Hits         5216     5220       +4     
- Misses       1005     1006       +1     
+ Partials      189      188       -1     
Impacted Files Coverage Δ
nmigen/lib/cdc.py 90.69% <100.00%> (+0.45%) ⬆️
nmigen/build/run.py 22.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765c15c...de1e825. Read the comment docs.

@whitequark whitequark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits:

  • By convention, all error checking happens at the function entry.
  • The error messages would be easier to read and more consistent with our other error messages if they used 1, not one.

@rroohhh

rroohhh commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

async_edge is also not checked at the function entry, should that be changed aswell?

@whitequark

Copy link
Copy Markdown
Member

Yup.

@whitequark whitequark merged commit 05decc4 into amaranth-lang:master Oct 28, 2020
@whitequark

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants