Drops support for Node 10.x, 12.x and adds 18.x #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
linlin-s
approved these changes
Sep 8, 2022
| matrix: | ||
| node-version: [10.x, 12.x, 14.x, 16.x] | ||
| node-version: [14.x, 16.x, 18.x] |
There was a problem hiding this comment.
Just a quick question here. According to the README.md, should this node-version also include 20?
There was a problem hiding this comment.
My mistake. README is wrong—Node 20 hasn't been released yet.
There was a problem hiding this comment.
My mistake. README is wrong—Node 20 hasn't been released yet.
Other than that, looks good to me.
linlin-s
approved these changes
Sep 8, 2022
desaikd
added a commit
that referenced
this pull request
Apr 24, 2023
* Drops support for Node 10.x, 12.x and adds 18.x (#723) * move to native `BigInt` from `JSBI` (#721) * Updates typedoc syntax to address warnings (#733) * updates test-driver to es2020 (#736) * Migrate linting from TSLint to ESLint (#737) * adds changes for resolving ion-test-driver build issue (#748) * adds changes to allow `dom.Decimal` construction from `Number` and `String` (#746) * updates uglify version * adds changes for upconverting JS value for dom collections (#749) * removes deprecated method `byteValue()` for v5.0.0 release (#750) * modifies `Struct#elements()` to return all field values (#754) --------- Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com> Co-authored-by: Delaney <delaneygillilan@gmail.com> Co-authored-by: Zack Slayton <zack.slayton@gmail.com> Co-authored-by: Andrey Lipatkin <400234+Litee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
This updates the supported versions of Node.js and bumps the version to
5.0.0-SNAPSHOT(since dropping support for old node is theoretically a backwards incompatible change).Note that this PR is against the
v5.0.0-developmentbranch, not against master.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.