adds changes for resolving ion-test-driver build issue #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desaikd
changed the title
zslayton
approved these changes
Mar 6, 2023
Comment on lines
+88
to
+89
| "typescript": "Mixed-in classes with functions returning `this` have TS2526 error is DTS file. Refernce issue: https://github.com/microsoft/TypeScript/issues/52687. Upgrade to a latest typescript version once this issue is resolved", | ||
| "typescript": "^3.9.10", |
There was a problem hiding this comment.
I haven't seen this pattern for documentation before. Is it common?
There was a problem hiding this comment.
There is no other way to add comments to package.json, we can't use the line comments(//or/**/). This seems to be the common way to add comments. Alternatively can add the comment to tsconfig but that might not be intuitive.
Closed
desaikd
added a commit
that referenced
this pull request
Apr 24, 2023
* Drops support for Node 10.x, 12.x and adds 18.x (#723) * move to native `BigInt` from `JSBI` (#721) * Updates typedoc syntax to address warnings (#733) * updates test-driver to es2020 (#736) * Migrate linting from TSLint to ESLint (#737) * adds changes for resolving ion-test-driver build issue (#748) * adds changes to allow `dom.Decimal` construction from `Number` and `String` (#746) * updates uglify version * adds changes for upconverting JS value for dom collections (#749) * removes deprecated method `byteValue()` for v5.0.0 release (#750) * modifies `Struct#elements()` to return all field values (#754) --------- Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com> Co-authored-by: Delaney <delaneygillilan@gmail.com> Co-authored-by: Zack Slayton <zack.slayton@gmail.com> Co-authored-by: Andrey Lipatkin <400234+Litee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #734, #747:
Description of changes:
This PR works on changing the
typescriptandtypedocversions to resolve generating broken DTS files. Currently typescript has an issue for mixed-in classes with functions returningthishave TS2526 error is DTS file.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.