Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change behavior of params.has_key? to match Crystal Lib Hash has_key? #1026

Closed
eliasjpr opened this issue Jan 7, 2019 · 0 comments
Closed

Change behavior of params.has_key? to match Crystal Lib Hash has_key? #1026

eliasjpr opened this issue Jan 7, 2019 · 0 comments
Labels
kind:bug status:help-wanted

Comments

@eliasjpr
Copy link
Contributor

eliasjpr commented Jan 7, 2019

Description

Currently the params.has_key?(key) returns the value or false. We should improve the behavior of this method to return Bool since []?(key) and [] methods and to match the Crystal::Hash(K, V).has_key? method behavior for API consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug status:help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drujensen @eliasjpr