Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation issues in amber generator #748

Closed
faustinoaq opened this issue Apr 11, 2018 · 3 comments
Closed

Indentation issues in amber generator #748

faustinoaq opened this issue Apr 11, 2018 · 3 comments

Comments

@faustinoaq
Copy link
Contributor

Description

I found some issues in generated code

  1. config/routes.cr:

screenshot_20180411_104313

    1. src/models/**:

screenshot_20180411_104455

  1. src/controllers/**:

screenshot_20180411_104540

screenshot_20180411_104639

Steps to Reproduce

  1. Create a new amber project
  2. Do some scaffolding
  3. Use crystal tool format --check

Expected behavior: Generated files are formatted well

Actual behavior: Generated files aren't formatted well

Reproduces how often: 100%

Versions

v0.7.2

Additional Information

crystal tool format --check output

➜  forum crystal tool format --check
Error: formatting './config/routes.cr' produced changes
Error: formatting './config/application.cr' produced changes
Error: formatting './config/initializers/database.cr' produced changes
Error: formatting './src/controllers/session_controller.cr' produced changes
Error: formatting './src/controllers/user_controller.cr' produced changes
Error: formatting './src/controllers/home_controller.cr' produced changes
Error: formatting './src/controllers/application_controller.cr' produced changes
Error: formatting './src/pipes/authenticate.cr' produced changes
Error: formatting './src/models/user.cr' produced changes
Error: formatting './src/models/tasks.cr' produced changes

^ This doesn't check .ecr or .slang files, so we should be careful with the indentation on these files.

@faustinoaq
Copy link
Contributor Author

faustinoaq commented May 17, 2018

@epergo Did your PR (#780) fix this? 😅

I guess there is still some indentation issues (see point 2. and 3. above)

@epergo
Copy link
Contributor

epergo commented May 17, 2018

Wops, I didn't see this issue. I only fixed config/routes.cr indentation.

@faustinoaq
Copy link
Contributor Author

@epergo No problem, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants