Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation when adding auth routes #780

Merged
merged 2 commits into from
May 10, 2018
Merged

Fix indentation when adding auth routes #780

merged 2 commits into from
May 10, 2018

Conversation

epergo
Copy link
Contributor

@epergo epergo commented May 6, 2018

Description of the Change

When generating Auth from template, a couple of routes are added with wrong indentation. This PR fix that.

Before:

  routes :web do
      get "/profile", PlayerController, :show
  get "/profile/edit", PlayerController, :edit
  patch "/profile", PlayerController, :update
  get "/signin", SessionController, :new
  post "/session", SessionController, :create
  get "/signout", SessionController, :delete
  get "/signup", RegistrationController, :new
  post "/registration", RegistrationController, :create
    get "/", HomeController, :index
  end

After:

  routes :web do
    get "/profile", PlayerController, :show
    get "/profile/edit", PlayerController, :edit
    patch "/profile", PlayerController, :update
    get "/signin", SessionController, :new
    post "/session", SessionController, :create
    get "/signout", SessionController, :delete
    get "/signup", RegistrationController, :new
    post "/registration", RegistrationController, :create
    get "/", HomeController, :index
  end

Copy link
Contributor

@faustinoaq faustinoaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Nice, Thank you!

@faustinoaq faustinoaq requested review from drujensen, marksiemers and a team May 6, 2018 19:34
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks, this kind of thing makes me smile

@robacarp robacarp merged commit 2225501 into amberframework:master May 10, 2018
@epergo epergo deleted the patch-2 branch May 10, 2018 08:42
@faustinoaq faustinoaq added this to the Version 0.8.0 milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants