Remove --deps flag from CLI header text #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option does not appear to work so it should not be shown to users in this text. ``` $ amber new myapp -d pg -t slang -m granite --deps Parsing Error: The --deps option is unknown. ```
|
It seems to have been set to default recently in @drujensen's changes. We should discuss the future of that flag here before removing it. Thanks for bringing that up. |
This was changed to --no-deps since most of the time you will want the shards install to run automatically.
drujensen
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option does not appear to work so it should not be shown to users in this text.
Description of the Change
Removes flag from command line in text.
Benefits
New users will be less confused.
Possible Drawbacks
Perhaps this flag should work and needs to be fixed?