Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring colorized output. #272

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Refactoring colorized output. #272

merged 3 commits into from
Sep 21, 2017

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented Sep 19, 2017

Description of the Change

  • Add --no-color flag. (available in amber run, amber routes and amber deploy)
  • Add color to environment settings. (allow to enable/disable colored output in logger and server)

With default configuration:

screenshot_20170919_175019

With color: false in environment config

screenshot_20170919_175100

Alternate Designs

Nop

Benefits

Fix #234

Possible Drawbacks

Nop

* Add --no-color flag.
* Add color to enviroment settings.
Copy link
Member

@drujensen drujensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@eliasjpr eliasjpr merged commit f37648a into amberframework:master Sep 21, 2017
@faustinoaq faustinoaq deleted the no-color branch September 21, 2017 13:43
marksiemers pushed a commit to marksiemers/amber that referenced this pull request Oct 28, 2017
* Refactoring colorized output.

* Add --no-color flag.
* Add color to enviroment settings.

* Fix description
elorest pushed a commit that referenced this pull request Nov 17, 2017
* Refactoring colorized output.

* Add --no-color flag.
* Add color to enviroment settings.

* Fix description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants