New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #349
Merged
Merged
Update dependencies #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea Why I'm getting these failures:
Updates seems to not change too much, @eliasjpr @amberframework/contributors WDYT? |
Wait until the cleanup of the tests gets merge is should fix these the failing tests |
elorest
approved these changes
Nov 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
eliasjpr
approved these changes
Nov 4, 2017
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Update dependencies * Remove branch comment * Fix shard build * Use test app name instead of path * More explicit build command to see failures * Downgrade mosop/cli * Try previous version of kilt
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Update dependencies * Remove branch comment * Fix shard build * Use test app name instead of path * More explicit build command to see failures * Downgrade mosop/cli * Try previous version of kilt Former-commit-id: edb4bb1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Update amber dependencies to latest version, see: https://shards.rocks/github/amberframework/amber
v0.1.0
: Create a release tag samueleaton/sentry#16Alternate Designs
No
Benefits
Use latest version, fixes dependencies bugs and vulnerabilities
Possible Drawbacks
Needs some breaking changes introduced in latest version of
mosop/cli
andkilt