Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #349

Merged
merged 10 commits into from Nov 4, 2017
Merged

Update dependencies #349

merged 10 commits into from Nov 4, 2017

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented Nov 1, 2017

Description of the Change

Update amber dependencies to latest version, see: https://shards.rocks/github/amberframework/amber

Alternate Designs

No

Benefits

Use latest version, fixes dependencies bugs and vulnerabilities

Possible Drawbacks

Needs some breaking changes introduced in latest version of mosop/cli and kilt

@faustinoaq faustinoaq mentioned this pull request Nov 1, 2017
6 tasks
@faustinoaq
Copy link
Contributor Author

No idea Why I'm getting these failures:

Failures:
  1) Amber::CLI::MainCommand::Perform performs a tasks via command line
     Failure/Error: runner.should eq "Fake task completed!"
       Expected: "Fake task completed!"
            got: nil
     # spec/amber/cli/commands/perform_spec.cr:19
  2) Amber::CLI::MainCommand::Perform performs a tasks via command line alias
     Failure/Error: runner.should eq "Fake task completed!"
       Expected: "Fake task completed!"
            got: nil
     # spec/amber/cli/commands/perform_spec.cr:25
  3) Amber::CLI::MainCommand::Perform shows task description
     Failure/Error: runner.should eq(
       Expected: "FirstFakeTask\t\t #First fake task\nSecond::FakeTask\t\t #Second fake task\nFakeTask\t\t #Fake command task\n"
            got: nil
     # spec/amber/cli/commands/perform_spec.cr:31
  4) Amber::CLI::MainCommand::Generate scaffold generates and compile generated app
     Failure/Error: File.exists?("./bin/#{TEST_APP_NAME}").should be_true
       Expected: true
            got: false
     # spec/amber/cli/commands/generator_spec.cr:20

Updates seems to not change too much, @eliasjpr @amberframework/contributors WDYT?

@faustinoaq
Copy link
Contributor Author

@eliasjpr Any clue about this, maybe we should merge #344 first ? 😅

@eliasjpr
Copy link
Contributor

eliasjpr commented Nov 1, 2017

Wait until the cleanup of the tests gets merge is should fix these the failing tests

Copy link
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@eliasjpr eliasjpr merged commit 05b486c into amberframework:master Nov 4, 2017
@faustinoaq faustinoaq deleted the patch-1 branch November 4, 2017 03:22
elorest pushed a commit that referenced this pull request Nov 17, 2017
* Update dependencies

* Remove branch comment

* Fix shard build

* Use test app name instead of path

* More explicit build command to see failures

* Downgrade mosop/cli

* Try previous version of kilt
elorest pushed a commit that referenced this pull request Nov 17, 2017
* Update dependencies

* Remove branch comment

* Fix shard build

* Use test app name instead of path

* More explicit build command to see failures

* Downgrade mosop/cli

* Try previous version of kilt


Former-commit-id: edb4bb1
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 12, 2018
@faustinoaq faustinoaq mentioned this pull request Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants