Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dependencies issues #333

Closed
6 tasks done
faustinoaq opened this issue Oct 27, 2017 · 3 comments · Fixed by #370
Closed
6 tasks done

New dependencies issues #333

faustinoaq opened this issue Oct 27, 2017 · 3 comments · Fixed by #370
Projects
Amber Framework 2017

Comments

@faustinoaq
Copy link
Contributor

faustinoaq commented Oct 27, 2017 •
edited

Description

The PR #319 solves and updates some dependencies, however some shards still keep outdated, these shards needs a bit more review before update them:

(wip) 👉 #349

Steps to Reproduce

  1. Open https://shards.rocks/github/amberframework/amber
  2. See outdated shards

Expected behavior: All shards are updated to latest version

Actual behavior: Some shards doesn't have a release tag or can't be updated because breaking changes.

Reproduces how often: 42.9 % (6.outdated_shards / 14.shards_dependencies)*100 # => 42.857

Versions

  • Amber 0.3.0
  • Crystal 0.23.1

Additional Information

Usecase & Issue by @veelenga 👉 #317
@eliasjpr
Copy link
Contributor

eliasjpr commented Nov 1, 2017

What’s the state of this issue? I think this was addressed no? Let’s trisge this issue

@faustinoaq
Copy link
Contributor Author

@eliasjpr This issue depends on #349 and has 3 remain issues, see tasklist.

@RX14 already said a new version of crystal-mysql should be published.

@faustinoaq faustinoaq mentioned this issue Nov 8, 2017
Merged
@faustinoaq
Copy link
Contributor Author

faustinoaq commented Nov 8, 2017 •
edited

Version mismatch and breaking dependencies:

  • Kilt (v0.4.0)
  • Mosop/cli (v0.6.10)

faustinoaq added a commit that referenced this issue Nov 9, 2017
@faustinoaq
Fix and update dependencies (#370)
096ce44 
* Fixes #333 
* Update crystal databases libraries.
* Update Kilt dependency
* Update Cli dependency
elorest pushed a commit that referenced this issue Nov 17, 2017
@faustinoaq
Fix and update dependencies (#370)
f201507 
* Fixes #333 
* Update crystal databases libraries.
* Update Kilt dependency
* Update Cli dependency
elorest pushed a commit that referenced this issue Nov 17, 2017
@faustinoaq
Fix and update dependencies (#370)
d232198 
* Fixes #333 
* Update crystal databases libraries.
* Update Kilt dependency
* Update Cli dependency


Former-commit-id: f201507
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 13, 2018
@faustinoaq faustinoaq mentioned this issue Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Amber Framework 2017
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and update dependencies amberframework/amber
2 participants
@eliasjpr @faustinoaq