fixes blocking cors issues #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgerator
force-pushed
the
nf/cors_issues
branch
from
f9ae11e
to
9ea731e
Compare
faustinoaq
approved these changes
May 21, 2018
fridgerator
force-pushed
the
nf/cors_issues
branch
from
9ea731e
to
b788d73
Compare
robacarp
approved these changes
May 23, 2018
fridgerator
force-pushed
the
nf/cors_issues
branch
from
b788d73
to
6b03dbe
Compare
|
Added a spec to check CORS response headers, including the header modified by this PR |
drujensen
approved these changes
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #799
Headers::ALLOW_METHODshould be plural linkmemoized
@_preflightvariable was being used across multiple requests@faustinoaq @eliasjpr just made the 2nd change related to the
@_preflightvariableBenefits
CORS pipe can be used with api / spa applications.
Possible Drawbacks
None