Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAGAIN used wrongly in WiFiClient.cpp available() function #114

Closed
S10143806H opened this issue Aug 24, 2022 · 3 comments
Closed

EAGAIN used wrongly in WiFiClient.cpp available() function #114

S10143806H opened this issue Aug 24, 2022 · 3 comments

Comments

@S10143806H
Copy link
Contributor

This issue was found and proposed by Ameba Arduino SDK user @jojoling regarding the PR in https://github.com/ambiot/ambd_arduino/pull/101/files.

@jojoling has mentioned the using of EAGAIN is incorrect in this modification, no function is handling EAGAIN (if there is no data available right now, try again later) according to the definition.

@ambiot
Copy link
Contributor

ambiot commented Aug 25, 2022

@jojoling can you give more details?

@jojoling
Copy link

EAGAIN it mean "error, try again".
It may have no problem in available function. but it cause time delay.

EAGAIN it also happen in other situation. Should it be ignore and wait for next ?

@S10143806H
Copy link
Contributor Author

S10143806H commented Aug 26, 2022

Hi @jojoling ,
Modification according to your issue feedback was updated in this PR: 8ac392a
Please verify it on your side as well. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants