Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new shapes currently available in StockEvents #27

Closed
debsush opened this issue Feb 29, 2016 · 7 comments
Closed

Adding new shapes currently available in StockEvents #27

debsush opened this issue Feb 29, 2016 · 7 comments

Comments

@debsush
Copy link

debsush commented Feb 29, 2016

Hi,

I would like the shapes feature to include the StockEvents types ("flag", "sign", "pin", "triangleUp", "triangleDown", "triangleLeft", "triangleRight", "text", "arrowUp", "arrowDown"). Is this possible to have these shapes added in colorful format

Regards,
SD

@martynasma
Copy link
Collaborator

You can use any SVG as a shape in annotation. Take a look at this section in the documentation:

https://github.com/amcharts/export#annotation-settings

It shows how you can define your own list of shapes.

However, the shapes will probably not be able to be shown in multiple colors.

@debsush
Copy link
Author

debsush commented Feb 29, 2016

Thank you for the prompt response. I have gone through the documentation. Based on what I understood, currently we can pick up the shapes from the shapes folder.

"shapes": [ "test.svg" ], // Choice of shapes offered in the menu (shapes are being loaded from the shapes folder)

I am not sure if the shapes folder "https://github.com/amcharts/export/tree/master/shapes" currently has the symbols that are part of the StockEvents. Was wondering if you could add these additional symbols to the folder mentioned above. As far as color is concerned, I only need the arrowDown and arrowUp symbols to be in available in RED and GREEN colors. Is it doable?

Regards,
SD

@martynasma
Copy link
Collaborator

No, those shapes are not there now. You can add any SVG there. I suggest looking for SVG icons on https://www.iconfinder.com/

You can then put those SVGs into shapes folder, then use shapes array to define which ones to add.

@debsush
Copy link
Author

debsush commented Feb 29, 2016

Thank you.

Current effort to upload the shapes into the shapes folder "https://github.com/amcharts/export/tree/master/shapes" is giving me the message

**_Uploads are disabled.

File uploads require push access to this repository.
_**
What is the default size that we should use. Do you use the 128*128 or some other configuration.

@martynasma
Copy link
Collaborator

Default built in size of the shapes are 32x32px.

However, that size does not matter a lot, since SVG is a vector-based format. So the images will scale without any loss to quality both ways.

@debsush
Copy link
Author

debsush commented Mar 2, 2016

Can I send you a list of icons downloaded from iconfinder.com and you can help me push those images into the Shapes folder as I do not seem to have the access level to push files into the Shapes folder.

Thank you
SD

@martynasma
Copy link
Collaborator

You will need to add those icons into your own folder. Or clone this repository and add those icons to your own. This way you will be able to keep main Export plugin files in sync, while at the same time maintain your own copy of the shapes folder.

@debsush debsush closed this as completed Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants