Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] win_tie_loss in Report.to_dict #17

Closed
PaulLerner opened this issue May 19, 2022 · 1 comment
Closed

[BUG] win_tie_loss in Report.to_dict #17

PaulLerner opened this issue May 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@PaulLerner
Copy link

Describe the bug

When converting a Report to dict, you only keep one metric while iterating over metrics (overwriting the previous metric in each loop)
https://github.com/AmenRa/ranx/blob/master/ranx/report.py#L315

How to fix
replace the line above with:
d[m1]["win_tie_loss"][m2][metric] = self.win_tie_loss[(m1, m2)][metric]
and init d[m1]["win_tie_loss"][m2] = {} at the same place as
https://github.com/AmenRa/ranx/blob/master/ranx/report.py#L309 (just above)
@PaulLerner PaulLerner added the bug Something isn't working label May 19, 2022
@AmenRa
Copy link
Owner

AmenRa commented May 19, 2022

Well spotted, thanks!

Fixed in v0.1.14.

@AmenRa AmenRa closed this as completed May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AmenRa @PaulLerner