Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ament_cmake_pytest needs a build_depend on ament_cmake_test. #439

Merged
merged 2 commits into from
Apr 11, 2023
Merged

ament_cmake_pytest needs a build_depend on ament_cmake_test. #439

merged 2 commits into from
Apr 11, 2023

Conversation

clalancette
Copy link
Contributor

This is so it can find and run the tests.

@clalancette
ament_cmake_pytest needs a build_depend on ament_cmake_test.
e6477d2 
This is so it can find and run the tests.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

Note well that CI here was only --packages-up-to ament_cmake_pytest and --packages-select ament_cmake_pytest. I could do a more full-on CI, but it really won't show very much and I wanted to keep this short.

@clalancette
Switch to buildtool_depend
2347e65 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

cottsay
cottsay approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to wait for CI - ci.ros2.org doesn't really care about the manifest contents.

Thanks!

@cottsay cottsay merged commit 0e46cf0 into rolling Apr 11, 2023
@cottsay cottsay deleted the clalancette/add-ament-cmake-test-dep branch April 11, 2023 22:04
@cottsay cottsay mentioned this pull request Apr 12, 2023
Merged
@clalancette clalancette mentioned this pull request Nov 7, 2023
Merged
ejalaa12 pushed a commit to ejalaa12/ament_cmake that referenced this pull request Nov 8, 2023
@clalancette @ejalaa12
ament_cmake_pytest needs a buildtool_depend on ament_cmake_test. (ame…
71e52d9 
…nt#439)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette pushed a commit that referenced this pull request Nov 10, 2023
@ejalaa12
backport merge #381 to humble (#490)
ca544b2 
* backport merge #381 to humble

* ament_cmake_pytest needs a buildtool_depend on ament_cmake_test. (#439)

* Add missing buildtool_depend on python3-pytest (#440)

* Fix test skipping logic for missing pytest module (#441)

Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjeronimo mjeronimo mjeronimo approved these changes

@cottsay cottsay cottsay approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clalancette @mjeronimo @cottsay