ament_cmake_vendor_package: Replace 'git' dep with 'vcstool' #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point in development, I switched from 'git' to 'vcstool' for fetching sources and forgot to update the manifest. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
The Rpr job should cover the syntax validation for this manifest change. Rosdeps are ignored on ci.ros2.org, so I don't plan to run any jobs there. |
Yadunund
approved these changes
Jun 16, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2023
At some point in development, I switched from 'git' to 'vcstool' for fetching sources and forgot to update the manifest. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 448647d) # Conflicts: # ament_cmake_nose/package.xml
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2023
At some point in development, I switched from 'git' to 'vcstool' for fetching sources and forgot to update the manifest. Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 448647d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in development, I switched from 'git' to 'vcstool' for fetching sources and forgot to update the manifest.
Should resolve the Rpr failure in ros2/rviz#995.