Add ament_auto_add_gmock to ament_cmake_auto #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very helpful! Thanks for the PR @jordan-palacios |
sloretz
reviewed
Oct 12, 2023
jordan-palacios
force-pushed
the
add_ament_auto_add_gmock
branch
from
b47f4f6
to
be50635
Compare
Similar rationale of ament_auto_add_gtest, but for gmock. ament_auto_add_gmock is a convinient macro that groups ament_add_gmock, target_include_directories, target_link_libraries and ament_target_dependencies in a single call for gmock tests. Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com>
This saves us from having to test_depend ament_cmake_gtest or ament_cmake_gmock directly in the target's package.xml Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com>
Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com>
jordan-palacios
force-pushed
the
add_ament_auto_add_gmock
branch
from
be50635
to
bdb7ea6
Compare
clalancette
approved these changes
Oct 16, 2023
|
CI:
|
|
@clalancette Thanks a lot! Do you think we could have this backported to |
jordan-palacios
added a commit
to jordan-palacios/ament_cmake
that referenced
this pull request
Nov 8, 2023
* Adding ament_auto_add_gmock to ament_cmake_auto Similar rationale of ament_auto_add_gtest, but for gmock. ament_auto_add_gmock is a convinient macro that groups ament_add_gmock, target_include_directories, target_link_libraries and ament_target_dependencies in a single call for gmock tests. * Added missing find_package for ament auto gtest and gmock This saves us from having to test_depend ament_cmake_gtest or ament_cmake_gmock directly in the target's package.xml Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com>
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Adding ament_auto_add_gmock to ament_cmake_auto Similar rationale of ament_auto_add_gtest, but for gmock. ament_auto_add_gmock is a convinient macro that groups ament_add_gmock, target_include_directories, target_link_libraries and ament_target_dependencies in a single call for gmock tests. * Added missing find_package for ament auto gtest and gmock This saves us from having to test_depend ament_cmake_gtest or ament_cmake_gmock directly in the target's package.xml Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com> (cherry picked from commit 261214a)
clalancette
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Adding ament_auto_add_gmock to ament_cmake_auto Similar rationale of ament_auto_add_gtest, but for gmock. ament_auto_add_gmock is a convinient macro that groups ament_add_gmock, target_include_directories, target_link_libraries and ament_target_dependencies in a single call for gmock tests. * Added missing find_package for ament auto gtest and gmock This saves us from having to test_depend ament_cmake_gtest or ament_cmake_gmock directly in the target's package.xml Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com> (cherry picked from commit 261214a) Co-authored-by: Jordan Palacios <j.palacios1986@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ament_auto_add_gtestoffers convenient macros for adding gtests.This PR extends
ament_cmake_autoto also offer support for gmock tests.Fixes #483.