Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake error when entire ament projects are added via add_subdirectory (backport #484) #487

Merged
merged 1 commit into from Nov 29, 2023
Merged

Fix CMake error when entire ament projects are added via add_subdirectory (backport #484) #487

merged 1 commit into from Nov 29, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Oct 11, 2023

This is an automatic backport of pull request #484 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@traversaro @mergify
Fix CMake error when entire ament projects are added via add_subdirec…
f457779 
…tory (#484)

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
(cherry picked from commit 53d31f3)
@mergify mergify bot requested a review from mjeronimo as a code owner October 11, 2023 16:41
@mergify mergify bot mentioned this pull request Oct 11, 2023
Merged
@sloretz sloretz self-assigned this Nov 2, 2023
@traversaro
Copy link
Contributor

Hello @sloretz @mjeronimo, thanks for creating the backport! There is anything I can do on my side to merge this? Thanks!

@traversaro traversaro mentioned this pull request Nov 18, 2023
Open
@sloretz
Copy link
Contributor

sloretz commented Nov 29, 2023

@Mergifyio rebase

@mergify Mergify
Copy link
Author

mergify bot commented Nov 29, 2023

rebase

✅ Nothing to do for rebase action

@sloretz
Copy link
Contributor

sloretz commented Nov 29, 2023

CI (repos file build: --packages-up-to rcutils test: --packages-select ament_cmake_core)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz sloretz merged commit 36a1ee4 into iron Nov 29, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/iron/pr-484 branch November 29, 2023 18:08
@traversaro
Copy link
Contributor

Thanks @sloretz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@traversaro @sloretz