Add ament_auto_add_gmock to ament_cmake_auto (backport #482) #493
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Adding ament_auto_add_gmock to ament_cmake_auto Similar rationale of ament_auto_add_gtest, but for gmock. ament_auto_add_gmock is a convinient macro that groups ament_add_gmock, target_include_directories, target_link_libraries and ament_target_dependencies in a single call for gmock tests. * Added missing find_package for ament auto gtest and gmock This saves us from having to test_depend ament_cmake_gtest or ament_cmake_gmock directly in the target's package.xml Signed-off-by: Jordan Palacios <jordan.palacios@pal-robotics.com> (cherry picked from commit 261214a)
|
CI (humble repos build:
|
|
Odd, seems like the DCO check is failing, even though the |
|
See here: https://github.com/ament/ament_cmake/pull/493/checks?check_run_id=18762976765 It's expecting an @gmail.com address as per the commit author email address, but the sign-off email is different. I think GitHub for some reason changes the commit author email to your GitHub email when merging. This can be manually approved, though. |
Yeah, I've manually set it, since the commit does have a DCO. I've also kicked off new CI, since it was run with incorrect arguments:
|
|
@clalancette Thanks for the fix! Since everything seems in order can we accept the PR? |
This is an automatic backport of pull request #482 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com