add option to pass extra env to ament_add_*test

[wjwwood]

I needed this to pass some environment to tests on OS X. I think the changes are pretty self explanatory.

One nice thing is that you can pass generator expressions through this variable and it works, e.g. I have the cmake code:

ament_add_gtest(test_allocator
    test/rcl/test_allocator.cpp
    ENV DYLD_INSERT_LIBRARIES=$<TARGET_FILE:${PROJECT_NAME}_memory_tools_interpose>)

Which results in these args to run_test.py:

3: Test command: /usr/local/bin/python3 "-u" "/Users/william/ros2/install/share/ament_cmake_test/cmake/run_test.py" "/Users/william/ros2/build/rcl/test_results/rcl/test_time.gtest.xml" "--output-file" "/Users/william/ros2/build/rcl/ament_cmake_gtest/test_time.txt" "--env" "DYLD_INSERT_LIBRARIES=/Users/william/ros2/build/rcl/librcl_memory_tools_interpose.dylib" "--command" "/Users/william/ros2/build/rcl/test_time" "--gtest_output=xml:/Users/william/ros2/build/rcl/test_results/rcl/test_time.gtest.xml"
3: Test timeout computed to be: 60
3: -- run_test.py: extra environment variables:
3:  - DYLD_INSERT_LIBRARIES=/Users/william/ros2/build/rcl/librcl_memory_tools_interpose.dylib
3: -- run_test.py: invoking following command in '/Users/william/ros2/build/rcl':
3:  - /Users/william/ros2/build/rcl/test_time --gtest_output=xml:/Users/william/ros2/build/rcl/test_results/rcl/test_time.gtest.xml
3: Running main() from gtest_main.cc
[ ... ]

[dirk-thomas]

Please add ENV before TIMEOUT (for alpha. order) and document it in the docblock above.

[dirk-thomas]

Should it be a multi-value argument instead to allow passing more then one?

[wjwwood]

Ok, I pushed an update and tested it locally with two environment variables. CI (for linux): http://ci.ros2.org/job/ci_linux/699/

[dirk-thomas]

+1