Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add INTERFACE option to ament_target_dependencies() #246

Merged

Conversation

dirk-thomas
Copy link
Contributor

Follow up of #235. Required for ros2/rmw#220. Related to ros2/ros2#904.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas self-assigned this Apr 22, 2020
@dirk-thomas
Copy link
Contributor Author

CI builds up to rclcpp, testing only the touched packages (for CMake linters):

  • Linux Build Status (unrelated compiler warnings)
  • Linux-aarch64 Build Status (unrelated compiler warnings)
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas merged commit fade242 into master Apr 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/ament_target_dependencies-interface-keyword branch April 23, 2020 01:33
j-rivero pushed a commit that referenced this pull request Apr 27, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants