Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport][galactic] Make ament_python_install_package() install console_scripts (#328) #364

Merged
merged 1 commit into from Dec 7, 2021
Merged

[backport][galactic] Make ament_python_install_package() install console_scripts (#328) #364

merged 1 commit into from Dec 7, 2021

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Nov 26, 2021

Backport #328 to galactic.

@hidmic
Make ament_python_install_package() install console_scripts (ament#328)
9c60d63 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@wep21 wep21 changed the title Make ament_python_install_package() install console_scripts (#328) [backport] [galactic] Make ament_python_install_package() install console_scripts (#328) Nov 26, 2021
@wep21
Copy link
Contributor Author

wep21 commented Nov 26, 2021

@hidmic @cottsay Could you review this?

@wep21 wep21 changed the title [backport] [galactic] Make ament_python_install_package() install console_scripts (#328) [backport][galactic] Make ament_python_install_package() install console_scripts (#328) Nov 26, 2021
@wep21 wep21 mentioned this pull request Nov 26, 2021
Merged
hidmic
hidmic reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment •
edited by cottsay

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks innocuous to me. @cottsay?

Galactic CI above ament_cmake_python:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit 573972a into ament:galactic Dec 7, 2021
@wep21 wep21 deleted the galactic-backport-328 branch December 7, 2021 19:20
@wep21
Copy link
Contributor Author

wep21 commented Dec 8, 2021

Could someone also create a PR to rosdistro? @hidmic @cottsay

@wep21 wep21 mentioned this pull request Dec 9, 2021
Merged
@rhaschke rhaschke mentioned this pull request Dec 29, 2021
Merged
@wmmc88 wmmc88 mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@cottsay cottsay cottsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wep21 @cottsay @hidmic